New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates binderhub chart to 1.0.0-0.dev.git.2816.h5db2f98 #2376

Merged

consideRatio merged 1 commit into master from update-chart-binderhub

Oct 24, 2022

Collaborator

jupyterhub-bot commented Oct 20, 2022 •

edited

Loading

Updates mybinder to depend on the binderhub chart version 1.0.0-0.dev.git.2816.h5db2f98 from version 0.2.0-0.dev.git.2782.h3ccfc44.

	Before	After
Chart.yaml's version	`0.2.0-0.dev.git.2782.h3ccfc44`	`1.0.0-0.dev.git.2816.h5db2f98`
Chart.yaml's appVersion	`null`	`null`

PRs

#1529 Rename master branch to main
#1544 Update to z2jh 2 and JupyterHub 3
#1555 helm chart: use modern chartpress and baseVersion 1.0.0-0.dev
#1557 build(deps): bump docker/setup-buildx-action from 2.0.0 to 2.1.0
#1558 [pre-commit.ci] pre-commit autoupdate
#1561 build(deps): bump docker/setup-buildx-action from 2.1.0 to 2.2.1
#1562 build(deps): bump peter-evans/create-pull-request from 4.1.3 to 4.2.0
#1564 binderhub image: refreeze requirements.txt

jupyterhub/binderhub@3ccfc44...5db2f98

Related

Chart source code: https://github.com/jupyterhub/binderhub/tree/master/helm-chart
Chart changelog:
Application changelog: https://github.com/jupyterhub/binderhub/blob/master/CHANGES.md

jupyterhub-bot added dependencies maintenance labels

Member

consideRatio commented Oct 20, 2022

This is a new duplicate PR of #2367. I recreated it to be 100% confident it was correctly outlining the relevant PR changes.

@manics noted in the previous PR that:

This includes a breaking change: Z2JH 2.0.0 and JupyterHub 3.0.0. This change is not easily reversible since it upgrades the JupyterHub DB.

Take care before merging! I'll mark this as draft to avoid an accidental merge.

consideRatio requested a review from minrk

October 20, 2022 11:06

Member

consideRatio commented Oct 20, 2022 •

edited

Loading

@minrk upgrading to JupyterHub 3 would imply user servers needs to be restarted typically, but would they need to be that also in this binderhub situation with non-typical authenticators etc?

The key question to answer is really how we should go about merging this though.

Member

minrk commented Oct 20, 2022

Because we don't use hub auth, I don't think servers need to be restarted (They shouldn't but that doesn't mean they don't).

The main thing a 2.0 upgrade does is drop all tokens, which doesn't affect Binder servers, which don't use those tokens.

This should be an attended upgrade, and plan for some disruption, though. Just in case.

Member

consideRatio commented Oct 20, 2022

@minrk I propose then I'll go for a merge in 45 minutes or so after a meeting, and then have a gke.mybinder.org server started to monitor for possible issues as a service user as well.

Member

manics commented Oct 20, 2022

Do we need to upgrade jupyterhub-singleuser in repo2docker or not?

Member

minrk commented Oct 20, 2022

Do we need to upgrade jupyterhub-singleuser in repo2docker or not?

That's a BinderHub issue more than a mybinder.org issue, since mybinder.org doesn't launch jupyterhub-singleuser.

Member

consideRatio commented Oct 20, 2022

Hmmm I'm unsure if this is acceptable to merge so I won't try it pending considerations about jupyterhub-singleuser in built images.


          Updates binderhub chart to 1.0.0-0.dev.git.2816.h5db2f98

a2e0ef5

jupyterhub-bot changed the title ~~Updates binderhub chart to 1.0.0-0.dev.git.2797.h951750e~~ Updates binderhub chart to 1.0.0-0.dev.git.2816.h5db2f98

jupyterhub-bot force-pushed the update-chart-binderhub branch from 35430bc to a2e0ef5 Compare

October 21, 2022 05:46

Member

minrk commented Oct 24, 2022

@consideRatio if you have time to watch it for a bit, this should be fine. The jupyterhub-singleuser shouldn't be an issue for mybinder.org since no jupyterhub code runs in user images.

consideRatio merged commit 259e723 into master

consideRatio deleted the update-chart-binderhub branch

October 24, 2022 08:01

Member

consideRatio commented Oct 24, 2022

Smooth sailing! :D Thanks @manics and @minrk !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies maintenance